Modelica_LinearSystems2 icon indicating copy to clipboard operation
Modelica_LinearSystems2 copied to clipboard

Remove function dorgqr_x

Open tobolar opened this issue 1 year ago • 3 comments

Function M_LS2.Math.Matrices.LAPACK.dorgqr_x shall be replaced with Modelica.Math.Matrices.LAPACK.dormqr. But https://github.com/modelica/ModelicaStandardLibrary/issues/4388 shall be resolved first since otherwise the new function call would look like: Modelica.Math.Matrices.LAPACK.dormqr(Q, Q, tau, "L", "N"), i.e. with doubled input of Q, which is odd.

tobolar avatar Apr 16 '24 13:04 tobolar

It seems the following replacement could be possible:

(Aout, info) := Modelica.Math.Matrices.LAPACK.dormqr(A, Q, tau, "L", "N");

instead of

(Aout, info) := Modelica_LinearSystems2.Math.Matrices.LAPACK.dorgqr_x(Q, tau);

with a predecessor (in both cases)

(Q, tau, info, work) := Modelica.Math.Matrices.LAPACK.dgeqrf(A);

tobolar avatar Apr 17 '24 07:04 tobolar