ModelicaStandardLibrary icon indicating copy to clipboard operation
ModelicaStandardLibrary copied to clipboard

Modelica.Magnetic.FluxTubes examples - comment from #4418

Open HansOlsson opened this issue 1 year ago • 3 comments

Two issues for Modelica.Magnetic.FluxTubes.Examples.MovingCoilActuator.ForceCurrentBehaviour and Modelica.Magnetic.FluxTubes.Examples.MovingCoilActuator.ForceStrokeBehaviour:

  1. I don't see why we have so short Interval (1e-4) for these two models in #4418

To me it seems 0.01 s would work as well, and if someone sets a very small Interval I expect that there is something relevant on that time-scale, and I don't know which signal. So, if there is something interesting on that time-scale, please enlighten me. (Note that Modelica.Magnetic.FluxTubes.Examples.MovingCoilActuator.ArmatureStroke has a small Interval since it simulates for a short time and has interesting dynamics.)

  1. The documentation is broken for those two models (and likely have been for quite some time) - it refers to flange_b for components that only have flange.

Originally posted by @HansOlsson in https://github.com/modelica/ModelicaStandardLibrary/pull/4418#pullrequestreview-2134384603

HansOlsson avatar Jun 28 '24 12:06 HansOlsson

@AHaumer can you please commen on that?

casella avatar Jun 28 '24 23:06 casella

I just compared two simulations and yes 100 ms is ok. We just have to take care of the reference results ... I'll have a look at the broken links.

AHaumer avatar Jul 02 '24 09:07 AHaumer

Broken links are cosmetics -> shifted to next release

AHaumer avatar Feb 11 '25 15:02 AHaumer