ModelicaStandardLibrary icon indicating copy to clipboard operation
ModelicaStandardLibrary copied to clipboard
verified publisher icon modelica

MSL 4.1.0 Regressions - Mechanics.Rotational and Mechanics.Translational

Open GallLeo opened this issue 1 year ago • 3 comments

The following models fail in result comparison. Tested revision: f9bddf86 (2024-02-16)

Changed models, need reference update after library officer check:

  • [x] Modelica.Mechanics.Rotational.Examples.EddyCurrentBrake - Reason: The component has been enhanced in a backwards compatible way with an optional excitation input, which is demonstrated by this upgraded example. @GallLeo pls. create new reference results. - Updated reference files?

  • [x] Modelica.Mechanics.Translational.Examples.EddyCurrentBrake - Reason: The component has been enhanced in a backwards compatible way with an optional excitation input, which is demonstrated by this upgraded example. @GallLeo pls. create new reference results. - Updated reference files?

  • [ ] Release notes check: All classes mentioned which could lead to result changes in user models? @GallLeo could you please feed the explanation to the release notes? Thx a lot!

Useful Links

Current comparison report: https://www.ltx.de/download/MA/Compare_MSL_v4.1.0/comparison_report_overview.html -> Reference result test -> Comparison

Comparison signal definitions: https://github.com/modelica/ModelicaStandardLibrary/tree/master/Modelica/Resources/Reference/Modelica https://github.com/modelica/ModelicaStandardLibrary/tree/master/ModelicaTest/Resources/Reference/ModelicaTest

Reference results: https://github.com/modelica/MAP-LIB_ReferenceResults

GallLeo avatar Feb 27 '24 08:02 GallLeo

All three points fine to me. @AHaumer after checking the points, you can please tick them all.

tobolar avatar Mar 01 '24 11:03 tobolar

@tobolar I won't tick the points, @GallLeo will do that as soon as he has created new reference results.

AHaumer avatar Mar 01 '24 17:03 AHaumer

@Esther-Devakirubai Can you please, whether the release notes mention EddyCurrentBrake?

GallLeo avatar Oct 21 '24 06:10 GallLeo

@Esther-Devakirubai Can you please, whether the release notes mention EddyCurrentBrake?

@GallLeo @Esther-Devakirubai this seems to be the remaining item on this issue.

maltelenz avatar Feb 11 '25 12:02 maltelenz

@GallLeo isn't this resolved now? If yes, pls. close

AHaumer avatar Feb 11 '25 15:02 AHaumer

@GallLeo isn't this resolved now? If yes, pls. close

It will be once it's been checked that the ReleaseNotes mention EddyCurrentBrake.

casella avatar Feb 11 '25 16:02 casella

It is mentioned in DifferencesTo400.html, see #4300. However, it seems not to be included in the current ReleaseNotes_4.1.0 branch

@Esther-Devakirubai can you please check why?

casella avatar Feb 24 '25 23:02 casella

ping @arunkumar-narasimhan

casella avatar Feb 27 '25 11:02 casella

ed895549 took care of that.

casella avatar Mar 09 '25 23:03 casella