python-sdk icon indicating copy to clipboard operation
python-sdk copied to clipboard

#552

Open DanielAvdar opened this issue 8 months ago • 1 comments

This pull request adds a new test to verify the fix for a Windows-specific process creation issue described in issue #552. The test ensures that the process creation function works without hanging.

Added test for Windows process creation:

  • tests/issues/test_552_windows_hang.py: Introduced a new test, test_windows_process_creation, to validate the functionality of _create_platform_compatible_process on Windows. The test uses a simple command (cmd /c echo Test successful) and sets a timeout to prevent hanging. It verifies that the process is created successfully and produces output.

DanielAvdar avatar May 13 '25 17:05 DanielAvdar

The test tests/issues/test_552_windows_hang.py is currently marked as xfail for hanging processes, which is the expected behavior. It will pass once the issue causing the hang is resolved. @ihrpr

DanielAvdar avatar May 14 '25 15:05 DanielAvdar

Addressed comments + reformated the test to be a true regression test such that it would fail without the fix (previous format was causing xfail if not hanging which is counterintuitive).

felixweinberger avatar Jul 08 '25 16:07 felixweinberger