MOC.ImageOptimizer icon indicating copy to clipboard operation
MOC.ImageOptimizer copied to clipboard

Do not lazy load CompilingEvaluator

Open soee opened this issue 1 year ago • 3 comments

In Neos 9 we have exception thrown due to wrong argument type when caliing Utility::evaluateEelExpression(). The expected type is EelEvaluatorInterface but the unresolved dependency injection is used instead. This commit marks the eelEvaluator propery as not be lazy loaded while injecting.

soee avatar Apr 30 '24 11:04 soee

Hmm, I use it in Neos 7 and 8 and have no issues.

dlubitz avatar May 01 '24 10:05 dlubitz

The fusion runtime also has to do this since ages as this is imo not a regression but a well known flaw which is also documented:

https://github.com/neos/neos-development-collection/blob/6af1939bb5dac41e58475f848cb90e4b82493e87/Neos.Fusion/Classes/Core/Runtime.php#L727-L731

see _activateDependency part in https://flowframework.readthedocs.io/en/7.3/TheDefinitiveGuide/PartIII/ObjectManagement.html#lazy-dependency-injection

mhsdesign avatar May 01 '24 11:05 mhsdesign

After upgrading to Neos 9, I'm getting the same exception. But only for some images it seems. I too didn't experienced this problem in Neos 7/8. Is there any update for this PR?

mikec655 avatar May 15 '25 06:05 mikec655