libnetwork icon indicating copy to clipboard operation
libnetwork copied to clipboard

docker-proxy-close-dangling-sockets

Open meermonster10 opened this issue 6 years ago • 5 comments

Make docker-proxy more resilient to CLOSE_WAIT and FIN_WAIT2 socket states. In case of unexpected connection terminations, do not wait indefinitely until both ends are closed. Signed-off-by: Jason Kim [email protected]

meermonster10 avatar Oct 10 '19 05:10 meermonster10

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" [email protected]:meermonster10/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle avatar Oct 10 '19 05:10 GordonTheTurtle

ss is showing my server full of CLOSE-WAIT connections from docker-proxy causing kernel TCP out of memory. Would this modification presumably solve that problem, and when could we expect it to hit stable?

Zer0t3ch avatar Jan 22 '20 14:01 Zer0t3ch

+1

Atl4sx avatar Jul 13 '20 08:07 Atl4sx

+1

litzk avatar Sep 10 '20 06:09 litzk

Note we have migrated this codebase over to github.com/moby/moby/libnetwork. We are not accepting PR's on this repo anymore except for backports to be included in moby 20.10

cpuguy83 avatar Jun 18 '21 22:06 cpuguy83