BitcoinChecker icon indicating copy to clipboard operation
BitcoinChecker copied to clipboard

Added lower and upper case distinction for content encoding.

Open Robert-SD opened this issue 6 years ago • 3 comments

This should fix issue #895. It enables data synchronization with Kraken API again. Many thanks @CedricCabessa for outlining the reason for the issue.

device-2019-09-16-201933

Robert-SD avatar Sep 16 '19 18:09 Robert-SD

Hello Robert. Since the app hasn't updated on play store from the developer, how can we build an apk with this change?

Armonistas avatar Sep 29 '19 21:09 Armonistas

I have the same question! It was an awesome app we should bring it back to life!

nachofq avatar Feb 14 '20 17:02 nachofq

@MaciejCiemiega, I think you're likely to see more breakage over time until this fix is committed and a new version released. The main reason is HTTP/2 compatibility, even for non-HTTP/2 clients. In order to simplify internal code, many major servers and proxies now only send along case-insensitive headers. This affects Apache, Nginx, and now HAProxy as of 2.0-2.1 with its new internal HTX representation.

The HTTP spec has never specified case-sensitive headers names, and Volley fixed its erroneous handling of headers on responses in https://github.com/google/volley/pull/91.

Short of pulling in a new version of Volley and using NetworkResponse.toHeaderMap(List<Header>), which is more correct but may be more work than you want to do, this patch fixes the issue, and should fix parsing errors on Binance, Kraken, BitMEX, and others.

STRML avatar Aug 06 '20 00:08 STRML