ocpp icon indicating copy to clipboard operation
ocpp copied to clipboard

use the library version number to publish to pypi, create a git tag and define a github release

Open ajmirsky opened this issue 1 year ago • 2 comments

Changes included in this PR

Depending on the project release process, hopefully this change to the publish-to-pypi github workflow will keep things consistent. After the project is published to pypi based on the version number in pyproject.toml, the same value is used to create a tag and a github release.

Impact

Keeps the version number consistent across pypi, git tag and github release by using the version number from pyproject.toml.

Checklist

tested additional functionality separately in a different repo, but since I don't have access to publish to pypi, I can't test the full flow.

ajmirsky avatar Dec 06 '24 19:12 ajmirsky

Not sure about this flow, my preference would be to create a new Github release as the first step which also creates a new tag, then check the diff and let GHA do the job of publishing to PyPi.

I believe the current workflow allows this direction. Is there something I'm missing which makes this workflow preferable?

mdwcrft avatar Dec 09 '24 07:12 mdwcrft

I believe the current workflow allows this direction. Is there something I'm missing which makes this workflow preferable?

One of the goal is the avoid to have a release on pypi without having a corresponding tag on the GitHub repo. To achieve it, @ajmirsky has moved everything to the workflow, including tag creation, GH release creation, ...: if one step fails, no release is done anywhere (almost). The automated changelog creation on GH and in the repo is still missing.

There's other way to achieve a full releasing automation in the python ecosystem I guess.

jerome-benoit avatar Dec 09 '24 10:12 jerome-benoit