ocpp icon indicating copy to clipboard operation
ocpp copied to clipboard
verified publisher icon mobilityhouse

add ConfigurationKeys

Open lbbrhzn opened this issue 4 years ago • 5 comments

added configuration keys (for v16 only)

lbbrhzn avatar Jul 06 '21 16:07 lbbrhzn

i added the configuration keys to enums.py, not sure if you need to update your schema_to_enums.py script to prevent them from being overwritten.

lbbrhzn avatar Jul 06 '21 16:07 lbbrhzn

Also, might be nice to separate the keys for the different profiles. What would be a good way to do that?

lbbrhzn avatar Jul 06 '21 17:07 lbbrhzn

Thanks for this @lbbrhzn, I guess you manually added all the keys, right? in order to avoid losing data, what I think we could do is to add an extra file, containing the original OCPP config keys, for 1.6 and read from there when we run the schema_to_enums.py, but not sure if it is the best idea

tropxy avatar Jul 08 '21 08:07 tropxy

Not sure either. Perhaps that's something you can do in a new pull request?

lbbrhzn avatar Nov 12 '21 17:11 lbbrhzn

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Feb 16 '22 12:02 sonarqubecloud[bot]

This PR is superseded by #413. Thanks @lbbrhzn

OrangeTux avatar Jan 24 '23 15:01 OrangeTux