pinny

pinny copied to clipboard

Reviewers: @fractaltheory @MikeKlemarewski @jansepar @mikenikles ## Changes - Opening a PR for this fix's visibility - The same fix can be seen on the `eddie-bauer` branch (https://github.com/mobify/pinny/compare/develop...eddie-bauer) so this seems...

marlowpayne

For latest Chrome 61 on Android. Linked PRs: https://github.com/mobify/lockup/pull/14 ## Changes - used the updated lockup plugin that fixes the `scrollTop` position ## TODOS: - [ ] Changes tested and...

vmarta

[Selector Utils](https://www.npmjs.com/package/selector-utils) and [Plugin](https://www.npmjs.com/package/mobify-plugin) have been published to NPM. Updating Pinny to use these deps ## Changes - Update NPM dependencies for `selector-utils` and `mobify-plugin` ## How to Test -...

marlowpayne

Look into adding CSS fix for pinny content not being scrollable

7

We've had a few issues with pinny content not being scrollable. The fix according to @vmarta has been to add the following CSS: // Force scrollable // - // //...

donnielrt

Pinny should close when the browser back button is pressed

4

We've been getting user feedback that users expect to be able to close Pinny by pressing the browser back button on their device. This means that instead of navigating back...

kpeatt

Steps to reproduce: 1. Open pinny 2. Change orientation 3. Focus on an input in pinny to bring soft keyboard up. Result: Pinny gets shifted downwards. It fixes itself when...

hcstephencheung

- [ ] `Esc` key should be mapped to closing the modal - [ ] A (perhaps overridable) description div should be included always - it's purpose is to describe...

hdhanani7

Should we provide a Pinny script prebuilt with all of the dependencies?

2

Using Pinny without using Require can be a little intense (even using Require can be a little intense). @MikeKlemarewski brought this up while trying to use it. Should we provide...

kpeatt