PSConsoleTheme icon indicating copy to clipboard operation
PSConsoleTheme copied to clipboard

Module not marked for Core

Open doctordns opened this issue 5 years ago • 2 comments

I am using this module (successfully) in PowerShell 7 RC3. However, if I look at the module details, I see it's set as just "Desk".

This should be changed. I think it's safe to just change this line in the manifest:

# from:

# Supported PSEditions
# CompatiblePSEditions = @()

# To:

# Supported PSEditions
CompatiblePSEditions =  'Core', 'Desktop'

doctordns avatar Feb 23 '20 13:02 doctordns

From what I've read, there is not need to set this unless there are differences in the module between the Core and Desktop editions. Additionally, once the key is set, it will prevent the module from importing on PowerShell 4 and below. I don't know that there are many people using older versions, but based on the content of the module it should technically be compatible with PowerShell 3.0 and above so I'd rather not set it unless it is absolutely necessary.

Where are you seeing "Desk" in the details? I have Core 7 RC2 installed and the CompatiblePSEditions is blank for me.

mmims avatar Feb 24 '20 17:02 mmims

I see this in the output of Get-Module. LIke this:

PS C:\foo> get-module psconsoletheme -list

    Directory: C:\Users\tfl.COOKHAM\Documents\PowerShell\Modules

ModuleType Version    PreRelease Name                 PSEdition ExportedCommands
---------- -------    ---------- ----                 --------- ----------------
Script     0.5.0                 PSConsoleTheme       Desk      {Get-ConsoleTheme, Set-ConsoleTheme}

doctordns avatar Feb 25 '20 21:02 doctordns