chattr icon indicating copy to clipboard operation
chattr copied to clipboard

Defaults don't seem to persist to `chattr` call

Open ghost opened this issue 2 years ago • 5 comments

Hello! Lovely little idea and package here. Been trying to get it running, but running into some snags.

Let me preface that I've been able to successfully run LlamaGPTJ-chat on the machine so I know that piece is working. I've been able to set the defaults and run chattr_test() to see that it's using the correct path and model, however when I go to run chattr from the console, it failed. I used the preview flag and found that it still references the old default directories. Attached screenshots to show.

Defaults are correct: Screenshot 2023-10-20 at 3 32 10 PM

Test is correct and runs, but preview flag shows a different path and therefore fails. Screenshot 2023-10-20 at 3 32 59 PM

ghost avatar Oct 20 '23 22:10 ghost

Hi there, I was running into the similar issue. And, the following methods seems to fix this issue specifically for me. Specify the type as console: chattr_defaults(type="console",path = "~/llama/chat-ubuntu-latest-avx2", model = "~/llama/ggml-gpt4all-j-v1.3-groovy.bin")

Hope it helps. Thanks, Edward

EdwardJ1n avatar Oct 23 '23 05:10 EdwardJ1n

Thanks. Didn't work in my case.

ghost avatar Oct 26 '23 22:10 ghost

I made some updates and I think this is fixes now, can you confirm?

> chattr_defaults()

── chattr ──────────────────────────────────────────────────────────────────────────

── Defaults for: Default ──

── Prompt: 
• Use the R language, the tidyverse, and tidymodels

── Model 
• Provider: LlamaGPT
• Path/URL: Library/LlamaGPTJ-chat/build/bin/chat
• Model: Library/ggml-gpt4all-j-v1.3-groovy.bin

── Model Arguments: 
• threads: 4
• temp: 0.01
• n_predict: 1000

── Context: 
Max Data Files: 0
Max Data Frames: 0
✖ Chat History
✖ Document contents
> chattr("test", preview = TRUE)

── chattr ──────────────────────────────────────────────────────────────────────────

── Preview for: Console 
• Provider: LlamaGPT
• Path/URL: Library/LlamaGPTJ-chat/build/bin/chat
• Model: Library/ggml-gpt4all-j-v1.3-groovy.bin
• threads: 4
• temp: 0.01
• n_predict: 1000

── Prompt: 
test(Use the R language, the tidyverse, and tidymodels)

edgararuiz avatar Mar 19 '24 22:03 edgararuiz

Hi Edgar,

Thanks a lot for looking into it.

We may move to GitHub Copilot and some home-made apps.

Thanks, Edward


发件人: Edgar Ruiz @.> 发送时间: 2024年3月20日 6:07 收件人: mlverse/chattr @.> 抄送: Edward Jin @.>; Comment @.> 主题: Re: [mlverse/chattr] Defaults don't seem to persist to chattr call (Issue #49)

I made some updates and I think this is fixes now, can you confirm?

chattr_defaults()

── chattr ──────────────────────────────────────────────────────────────────────────

── Defaults for: Default ──

── Prompt: • Use the R language, the tidyverse, and tidymodels

── Model • Provider: LlamaGPT • Path/URL: Library/LlamaGPTJ-chat/build/bin/chat • Model: Library/ggml-gpt4all-j-v1.3-groovy.bin

── Model Arguments: • threads: 4 • temp: 0.01 • n_predict: 1000

── Context: Max Data Files: 0 Max Data Frames: 0 ✖ Chat History ✖ Document contents

chattr("test", preview = TRUE)

── chattr ──────────────────────────────────────────────────────────────────────────

── Preview for: Console • Provider: LlamaGPT • Path/URL: Library/LlamaGPTJ-chat/build/bin/chat • Model: Library/ggml-gpt4all-j-v1.3-groovy.bin • threads: 4 • temp: 0.01 • n_predict: 1000

── Prompt: test(Use the R language, the tidyverse, and tidymodels)

— Reply to this email directly, view it on GitHubhttps://github.com/mlverse/chattr/issues/49#issuecomment-2008221681, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQJ6FMKQBVGYJWTTAKJR4JDYZCZIPAVCNFSM6AAAAAA6JU6ZW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBYGIZDCNRYGE. You are receiving this because you commented.Message ID: @.***>

EdwardJ1n avatar Mar 28 '24 02:03 EdwardJ1n

TLDR; defaults persist now!

hi all - I was also running into this issue back in November 2023. I had pivoted to gpt4all via Python..

However, I noticed the chattr changelog (CRAN release: 2024-04-27) and figured I'd read up on the project again. Based on my tests, the edits @edgararuiz mentioned are working!

Changed defaults successfully, chattr_test() was successful, and chattr() works as intended now. image

@edgararuiz thank you!

frankiethull avatar May 14 '24 04:05 frankiethull