tiny icon indicating copy to clipboard operation
tiny copied to clipboard

[API] Enable access to data buffer

Open mehrdadh opened this issue 4 years ago • 5 comments

Hi, For microcontrollers with limited memory, we can optimize memory usage by directly passing gp_buff to inference machine instead of copying the data to a separate memory. For some microcontrollers this is a huge amount of memory and it's a matter of whether the model/runtime fits on device or not. I'll be happy to change the implementation if there is any suggestion.

Thanks.

mehrdadh avatar Jun 23 '21 00:06 mehrdadh

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

github-actions[bot] avatar Jun 23 '21 00:06 github-actions[bot]

This looks like a great addition!

My suggestion is that we add this change to the next version of the benchmark and keep v0.5 frozen for posterity.

We should be starting on a new version soon so I'll leave this PR up for now.

colbybanbury avatar Jun 23 '21 14:06 colbybanbury

@colbybanbury that sounds great. Thanks! Also I have signed the CLA google form and I think my github account will be added soon.

mehrdadh avatar Jun 23 '21 16:06 mehrdadh

Hi @colbybanbury, We could potentially add a tag to the current commit and label it as v0.5 and move forward with the development on main branch. wdyt? We can also discuss it in the next meeting.

Thanks.

mehrdadh avatar Jun 24 '21 22:06 mehrdadh

Friendly reminder about this PR. We're using this change in our future submission and I appreciate if we can decide if we could merge this to the API. thanks!

mehrdadh avatar Aug 01 '22 15:08 mehrdadh