medperf icon indicating copy to clipboard operation
medperf copied to clipboard

Improved integration tests

Open VukW opened this issue 1 year ago • 2 comments

  • now config.yaml location can be defined with custom value (env var)
  • integration tests use a new /tmp/ folder storage with every run
  • After every command db is backed up to /tmp/%dir%/snapshots/ for easy debug
  • Every command is printed before execution

NB: despite of it simplifies tests rerun, one still need to reset db storage manually before tests run: ./reset_db.sh && python seed.py

VukW avatar Apr 09 '24 15:04 VukW

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

github-actions[bot] avatar Apr 09 '24 15:04 github-actions[bot]

Hi @hasan7n thanks, you are right, moved config&storage init to tests_setup.sh.

Also updated "storage moving": instead of real moving files back and forth (that may be error-prone if broken on the mid) we explicitly point config pathes to a newly created empty tmp folder. That is safer IMO

VukW avatar May 06 '24 14:05 VukW

@hasan7n fixed, ready for re-review:)

VukW avatar May 07 '24 14:05 VukW