inference icon indicating copy to clipboard operation
inference copied to clipboard

LlaMa2-70b run_accuracy.sh issue with consolidate_results.py

Open mrmhodak opened this issue 1 year ago • 2 comments

LlaMa2-70b has a run_accuracy.py script that as a last step that calls another script, consolidate_results.py. That last step does not work, it expects to read output pkl files, but those are not being created in previous steps.

The README marks this step as optional - so we should either remove if not needed, or fix.

@nvzhihanj , please help.

mrmhodak avatar Feb 26 '24 02:02 mrmhodak

I believe the consolidate_results.py is not needed if the pickle input file already has all the samples (24576). That script is a by-product of preprocessing that @nv-alicheng uses IIRC.

nvzhihanj avatar Feb 26 '24 04:02 nvzhihanj

consolidate_results.py is an optional step that was used to generate a pickle file for manual viewing / data analysis. It is not required to run the accuracy script. The pkl files that it consumes are generated here (https://github.com/mlcommons/inference/blob/master/language/llama2-70b/dataset.py#L90) during the accuracy inference.

nv-alicheng avatar Feb 26 '24 15:02 nv-alicheng