inference icon indicating copy to clipboard operation
inference copied to clipboard
verified publisher icon mlcommons

Proposal: Change all module/folder name from hyphen to underscore

Open nvzhihanj opened this issue 2 years ago • 2 comments

Python module disallows usage of hyphen ('-') in module name, and it makes importing and module run very complicated. We should change the naming of folder and module (e.g. llama2-70b) to use underscore. @pgmpablo157321 FYI

nvzhihanj avatar Feb 05 '24 21:02 nvzhihanj

Affects 3D-UNet, Llama2-70B, DLRM-v2 Leaving open for now, can affect workflow @arjunsuresh and @gfursin : Any comments?

mrmhodak avatar Apr 02 '24 17:04 mrmhodak

@nvzhihanj and @mrmhodak - we should be able to support such changes in CM. Please ping us if/when this change is done so that we could test all our workflows. Thanks!

gfursin avatar Apr 02 '24 17:04 gfursin