chakra icon indicating copy to clipboard operation
chakra copied to clipboard
verified publisher icon mlcommons

[ETFeeder] Speedup et_feeder and resolve uninitialized attrs values in ETFeederNode

Open changhai0109 opened this issue 2 years ago • 3 comments

  1. Updated ETFeeder::readNextWindow to speed up by removing some extra resolveDeps() calls.
  2. Assigned default values of attrs in ETFeederNode to avoid uninitialized variables and leading undefined behavior with -O3 compile flag.

changhai0109 avatar Dec 12 '23 00:12 changhai0109

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

github-actions[bot] avatar Dec 12 '23 00:12 github-actions[bot]

@mlcommons/wg-chakra

Hi, ppl, for PR #7, #8, #9, #10, and #11, they have been stalled for weeks.

Is there any blocker preventing merging them? Please leave any comments if there are any concerns about these PRs. Thanks!

changhai0109 avatar Jan 22 '24 21:01 changhai0109

Those two commits look good to me! @changhai0109 Thank you for the PR. We've got minor a conflict in ET_Feeder. Could you solve that please?

JoongunPark avatar Feb 06 '24 21:02 JoongunPark