chakra icon indicating copy to clipboard operation
chakra copied to clipboard

keep original data_deps while resolving graph

Open changhai0109 opened this issue 1 year ago • 2 comments

Target Issue #148

Summary

One of the future works on astrasim about memory requires getting the original data dependency from the workload. However, in the current implementation of ETFeeder the original data_deps will be mutated for recording dependency resolving. Here we introduce a duplication of data_deps called unresolved_data_deps which is specifically used for dependency resolving. This way we can keep original data_deps during resolving for purples of memory analysis.

Test Plan

Test it with AstraSIM run/example

changhai0109 avatar Aug 20 '24 16:08 changhai0109

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

github-actions[bot] avatar Aug 20 '24 16:08 github-actions[bot]

Hi @changhai0109, Thank you for resolving my questions!

May I request, you to ensure that the code passes all checks (File formatting, tests, etc.)?

JoongunPark avatar Sep 15 '24 19:09 JoongunPark