Fix PR #29

[code28]

I liked the idea of not having a private container (Issue #26 and Pull request #29). Since there was no development since june, I took a look and fixed two little things (one of them fixes #30), so now I think it works.

So the main work for this was done by @siemensikkema, I just made two tiny fixes to make it work. :)

[codecov[bot]]

Codecov Report

Merging #34 into master will not change coverage. The diff coverage is 0%.

@@         Coverage Diff          @@
##           master   #34   +/-   ##
====================================
  Coverage       0%    0%           
====================================
  Files           8     6    -2     
  Lines         107    84   -23     
====================================
+ Misses        107    84   -23

Impacted Files	Coverage Δ
Sources/Flash/Providers/FlashProvider.swift	0% <ø> (ø)	:arrow_up:
Sources/Flash/Models/Flash.swift	0% <ø> (ø)	:arrow_up:
Sources/Flash/Extensions/Container+Flash.swift	0% <0%> (ø)
Sources/Flash/Tags/FlashTag.swift	0% <0%> (ø)	:arrow_up:
Sources/Flash/Middlewares/FlashMiddleware.swift	0% <0%> (ø)	:arrow_up:
Sources/Flash/Extensions/Future+Flash.swift	0% <0%> (ø)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8763c73...1124b4a. Read the comment docs.

[steffendsommer]

@code28 thanks a lot for following up on this - and we're sorry for the delay. Let's have @siemensikkema go through your PR.

[siemensikkema]

@code28 Thanks for the PR! It seems the way the flashes are en/decoded to and from the session still uses the private container and the README still mentions that the private container should be used. A different approach to solving this is to pass the request into the render function using the functionality from https://github.com/nodes-vapor/sugar/blob/master/Sources/Sugar/Helpers/Render%2BuserInfo.swift (see: https://github.com/nodes-vapor/sugar/releases/tag/3.0.0-beta.18). Only issue is now that the we need to remember to pass in the request but at least the view can be rendered the normal (cached) way.

[code28]

Well, it seems to me, that the privateContainer is not necessary anymore. I tried removing privateContainer part when en-/decoding to and from the session, and it still works. In general, I don't use private containers for flashes at all in my project and it works.

I must admit, that I don't fully understand the principle of private containers here, but I have the impression, that we can remove it here.

I can fix the readme, as soon as we found the way to go :)

[siemensikkema]

@code28 I believe that when using the normal container you use the one that is for the event loop and therefore shared by all the requests. I'd expect you'd run into problems where flashes from different requests (different users) would appear.

[code28]

Well, I just tested with two different users at the same time and not a private container, but the flashes were seperately for each user...