mkropat
handle spaces in WM_CLASS
The issue has been described here: https://github.com/mkropat/jumpapp/issues/51#issuecomment-607414376
The first commit replaces the space separation by tab separation (SEP=$'\t') regarding the ”columns“ windowid hostname pid workspace class title. I also updated
The second commit contains the actual change, using xprop … WM_CLASS instead of wmctrl's -x option. This is slower than wmctrl, but still the fastest solution I could come up with. It works very well on my old laptop. By the way, in PR #86 I improved the performance of the script, somewhat compensating the performance loss.
PS: Of course, adapting wmctrl could make it faster, but this would introduce another dependency, complicating the installation of jumpapp.
Thanks for the contribution! Making jumpapp handle WM_CLASS more robustly is a good idea.
I don't have time to give this change a proper review now (I see you updated the tests—thanks!). What I'll do though is switch to this branch and run it for a while, as a way to gain confidence in the change.
If anyone wants to try this out and/or review it, I'll strongly consider that for merge. Otherwise I'll review this sometime when I get a chance.
I've had no issues running this for a few months. Merging. Thanks again for the contribution.