sunset

sunset copied to clipboard

example code

4

this could use an example for non-async, non-std. i had to patch in a custom `getrandom` impl to use: ``` #[path = "espidf.rs"] mod imp; ``` for some reason `if...

keredson

async/examples/serv1 does not compile

1

When I run ``` git clone https://github.com/mkj/sunset.git cd sunset/async cargo run --example serv1 ``` I get a bunch of compile errors. Have the latest Rust version (1.78).

lasiotus

Dev/sftp start: Implementing basic SFTP functionality

18

Hi there @mkj, This is an early draft of a pull request to help with the SFTP subsystem for sunset. I have been reading and working on `proto.rs` and I...

jubeormk1

embassy-net `TcpReader::read_with()` can be used to avoid the 1 kB copy buffer. Figure if there's a way to automatically specialise that.

mkj

progress() might need to send output packets but the `TrafSend` may not have space. Would it be OK to check for empty `TrafSend` at the top of progress()?

mkj

Channel cleanup is definitely not all correct, in terms of EOF->close, and shutting down one direction before the other.

mkj

Perhaps `DispatchEvent` could be renamed `EventId`. `disconnected` would instead map to an `Event`.

mkj

Currently it's assumed an application will exit if an event callback returns an error (for example `.hostkeys()?` if buffer space isn't available). It might be worth storing that error somewhere...

mkj