uber-rush icon indicating copy to clipboard operation
uber-rush copied to clipboard

Remove either production or sandbox option

Open pstoica opened this issue 9 years ago • 4 comments

...unless there's ever a reason to set both to true or false. But so far it's always only one.

pstoica avatar Apr 27 '16 15:04 pstoica

Fair enough! My instinct is to default to sandbox, and require explicit production opt-in. What do you think?

mjk avatar Apr 27 '16 16:04 mjk

I was thinking opposite (sandbox: true) since you don't often see an API wrapper that mocks by default.

pstoica avatar Apr 27 '16 16:04 pstoica

Haha. But you don't see an API that makes a guy ride his bike by default either (and, more seriously, Uber right now doesn't immediately grant you the production scope; you have to get validated by their AMs before you graduate from the sandbox scope).

On Wed, Apr 27, 2016 at 12:21 PM, Patrick Stoica [email protected] wrote:

I was thinking opposite (sandbox: true) since you don't often see an API wrapper that mocks by default.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/mjk/uber-rush/issues/4#issuecomment-215137112

mjk avatar Apr 27 '16 16:04 mjk

Oh, I didn't realize they literally provided sandbox endpoints. Okay, sounds fine! production: true

pstoica avatar Apr 27 '16 16:04 pstoica