mixpanel-php icon indicating copy to clipboard operation
mixpanel-php copied to clipboard

Switched to classmap

Open nrbrook opened this issue 12 years ago • 4 comments

I have switched to classmap by changing the composer.json file and removing the now unnecessary requires in Mixpanel.php. I think this works...needs some testing. This was in response to https://github.com/mixpanel/mixpanel-php/issues/8

nrbrook avatar Dec 20 '13 16:12 nrbrook

Thanks for the pull request. My main concern is that I want people who are using php < 5.3 to be able to use this library. Correct me if I'm wrong, but I believe that by switching to classmap it will require namespacing

jbwyme avatar Jan 29 '14 00:01 jbwyme

Composer requires php >5.3.2 so it doesn't matter. Just leave in the requires if you want it to be compatible with php < 5.3.

nrbrook avatar Jan 29 '14 08:01 nrbrook

Classmap is used to auto load libraries that do not comply with psr-0, so you don't need to use namespaces. As you can see in my pull request it doesn't add namespaces.

nrbrook avatar Jan 29 '14 08:01 nrbrook

Oh ok great I'll do some testing with it and see about getting it merged. Thanks!

jbwyme avatar Jan 29 '14 18:01 jbwyme