morphic icon indicating copy to clipboard operation
morphic copied to clipboard

Use PPR for instant homepage response

Open cramforce opened this issue 1 year ago • 5 comments

cramforce avatar Apr 09 '24 03:04 cramforce

@cramforce is attempting to deploy a commit to the morphic Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 09 '24 03:04 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
morphic ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 9:41pm

vercel[bot] avatar Apr 10 '24 07:04 vercel[bot]

Requested access.

I can look into PPR compat. Actually, if all you do is switch away from edge runtime (which doesn't support static optimization) then it might just become static algothether

cramforce avatar Apr 10 '24 12:04 cramforce

Access granted.

Thank you for your support. It seems that this might be related to the following issue as well: https://github.com/miurla/morphic/pull/5#issuecomment-2046767332

miurla avatar Apr 10 '24 14:04 miurla

There was a bug up until 14.2.2 with streaming + server actions + Node.js that has since been resolved. Thanks for helping pinpoint things here, appreciate it. Should work now, if you want to approve that deployment.

https://github.com/miurla/morphic/pull/5#issuecomment-2100788459

This bug was fixed and merged into main, so I pulled the main branch and checked, but it didn't stream. To apply ppr, it needs to be on canary, and it might be a separate issue.

Using PPR might be too early for our project.

miurla avatar May 09 '24 00:05 miurla

@cramforce I'll close this PR once. Depending on the status of the PPR, I'll decide whether to merge this PR or to implement it again if necessary. Thank you for your support.

miurla avatar May 09 '24 23:05 miurla