caldera icon indicating copy to clipboard operation
caldera copied to clipboard

Plugin hook update

Open bjeffries opened this issue 1 year ago • 2 comments

Description

This pull request addresses issues #3078 and #3079.

Currently there is a bug identified in #3078 that prevents the existing builder plugin from hooking the executor outside of the planning service. This is addressed by adding a similar check in the operations api manager.

Looking at the bigger picture, the executor hook check was specialized just for the builder plugin. The change below will parse through any hook that is added to the executor hook data structure allowing for other plugins to easily leverage this capability.

Type of change

  • [X] Bug fix (non-breaking change which fixes an issue)
  • [X] This change requires a documentation update

How Has This Been Tested?

I have tested these changes on Caldera v5 with a plugin that leverages this hooking method to edit ability files before they are staged for an agent.

Checklist:

  • [X] My code follows the style guidelines of this project
  • [X] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works

bjeffries avatar Dec 03 '24 20:12 bjeffries

Can address the suggestions above and update the PR for approval

deacon-mp avatar Oct 06 '25 22:10 deacon-mp