Unreadable log due to messed variables in code 'id' and 'ablity_id'

[Morpheme777]

Describe the bug Unreadable caldera log: We get the string <built-in function id> instead of 30cfed4036baf152888affdcd814312c

To Reproduce Steps to reproduce the behavior:

1. place an ability .yml file to the folder with invalid tactic name (where 'tactic' inside the .yml file not equal folder name)
2. look at log file, a error ERROR (data_svc.py:168 load_ability_file) Ability=<built-in function id> has wrong tactic should be generated

Expected behavior

Screenshots see above

Desktop (please complete the following information):

• OS: Kali
• Caldera: 4.0.0

Additional context Solution: In the file app/service/data_svc.py -> def load_ability_file -> self.log.error('Ability=%s has wrong tactic' % id) id should be replaced with ability_id

[github-actions[bot]]

Looks like your first issue -- we aim to respond to issues as quickly as possible. In the meantime, check out our documentation here: http://caldera.readthedocs.io/

[mkultraWasHere]

@Morpheme777 Want to open a PR?

[Morpheme777]

@Morpheme777 Want to open a PR?

PR is opened.

[github-actions[bot]]

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 5 days

[mkultraWasHere]

Closed in #2642