jQuery-QueryBuilder icon indicating copy to clipboard operation
jQuery-QueryBuilder copied to clipboard

Hidden Rules

Open gordon-matt opened this issue 5 years ago • 4 comments

This relates to issue #825 . My colleague has left the organization, so I forked his work and am submitting it here.

gordon-matt avatar Apr 16 '20 06:04 gordon-matt

  1. please do not modify the README, add things that should be in the doc, add new dependencies or modify the existing example
  2. I don't want to integrate that in the core, it has to be a plugin

It's clearly a WIP for your need and cannot be integrated as it.

mistic100 avatar Apr 16 '20 11:04 mistic100

Yeah, like I tried to say: I didn't modify anything.. it was my colleague and he is gone now.. so I thought I'd just submit this Pull Request so we don't lose the code changes he did.

If you don't like the way he implemented it, sure.. no worries. Just leave it here to look at when you have the time to do your own implementation and then close it when you're done.

gordon-matt avatar Apr 17 '20 13:04 gordon-matt

Ok. BTW openning a pull request won't prevent to lose the code. Your repository is the only owner of this code.

mistic100 avatar Apr 17 '20 13:04 mistic100

Yes, but this way you can more easily see what has been changed, which may (or may not) give you inspiration for your own implementation.

gordon-matt avatar Apr 30 '20 00:04 gordon-matt