omdb icon indicating copy to clipboard operation
omdb copied to clipboard

Updating package.

Open Fazendaaa opened this issue 7 years ago • 0 comments

Hey, @misterhat. Thanks for this awesome package!

Due to Hacktoberfest 2018, I'm contributing to some packages that I use; yours is one of those.

I was going to only make TypeScript(TS) typings to your package, but since it was an old package I've decided to make some changes:

  • [x] Using promises instead of callbacks;
  • [x] Removing ALL packages dependencies, making it less likely to need to update it in a near future;
  • [x] Added a .npmignore;
  • [x] Rewriting in TS;
  • [x] Integrating linter standards;
  • [x] Setting git hooks with Husky;
  • [x] Using Webpack to handle file integration;
  • [x] Writing new and more comprehensive tests with Jest;
  • [x] Continuous Integrations (CI) with:
    • Travis CI
    • Codecov
    • Codeclimate
  • [x] Updating docs;
  • [x] Making use of typedoc to integrate with Github pages -- https://fazendaaa.github.io/omdb/;
  • [x] Linked typings file in your package.json -- making no need to submit to @types;

TODO:

[ ] If you decided to accept this PR, please be aware of modifying the README.md, a simple regex replacing all of Fazendaaa to misterhat gets the job done; [ ] Create an account, if not existing, in all of the CI services -- they are free for Open Source projects; [ ] Just go to your repo settings and activate the Github pages options.

That's it, thanks again and keep doing this awesome work :)

Fazendaaa avatar Oct 07 '18 23:10 Fazendaaa