Recieve and Apply Mastodon Note Edits

[nullobsi]

Summary

Receive AP Update for Note objects.

My ideas:

• display a "pencil" icon/button on edited posts that leads to a page with post history, on hover will show last edited date
• Store Note history under a new table note_history with unique index id, and index note_id
  • On Update, create a new entry under note_history with old content and old date
  • Add new edited_date as a nullable column to note
• Add API endpoints to get array of post history

[nullobsi]

implementing the whole "note history" would be more difficult. But it would make for a better experience (if a post is edited to offensive content -> etc...) However, a stopgap could be simply directly changing note content in the DB, until such a history feature could be realized

[Johann150]

However, a stopgap could be simply directly changing note content in the DB, until such a history feature could be realized

There should at least be a hint that the note was changed. Otherwise popular notes could be changed after getting popular etc.

[ThatOneCalculator]

There should at least be a hint that the note was changed. Otherwise popular notes could be changed after getting popular etc.

Perhaps a little pencil icon?

[nullobsi]

I think it would fit better with the other icons in the top right of the note; but otherwise yes

[Johann150]

Another concern is what is allowed to be updated. In the Pleroma merge request that was linked in the other issue there is a list of updateable properties in lib/pleroma/constants.ex that we could probably copy. ※Pleroma is also AGPL licensed.

Note also that it seems to be forbidden to change the options of a poll or change poll options between anyOf and oneOf. Updating the vote count is of course possible, as it is already possible. See maybe_update_poll in lib/pleroma/object/updater.ex.

On another note I thought that Mastodon said they implemented updating posts as well, but their website still says:

Update = only supported on polls. Used to refresh vote count. -- https://docs.joinmastodon.org/spec/activitypub/#status

[ThatOneCalculator]

IIRC the Mastodon docs are out of date 😄

[Freeplayg]

I think this is more important now that Mastodon 4.0 is releasing with editing posts in the UI

[tamaina]

個人的な意見

• Misskeyにノート編集(notes/update, Note Update)を実装する必要はない、編集すると何に対してリアクションしたかが変わってくるので削除して編集の方が適切だと思う
• Mastodonなどの他のソフトで行われた変更を受信した際は編集を適用しリアルタイムに反映する必要がある
• Misskeyでリモートの編集履歴を保持する必要はない、編集履歴はオリジナルを参照すれば良い（Mastodonは嘘をつかないだろう）
  編集済みフラグを保持し、何かしらの編集がされたことを表示するだけ

[saschanaz]

Mastodonなどの他のソフトで行われた変更を受信した際は編集を適用しリアルタイムに反映する必要がある

In addition, users should also be notified by any edits (as Mastodon currently does) so that anyone reacted can cancel/modify theirs.

編集が行われた場合、リアクションを変更できるように通知も必要になります。

[kabili207]

• Misskeyにノート編集(notes/update, Note Update)を実装する必要はない、編集すると何に対してリアクションしたかが変わってくるので削除して編集の方が適切だと思う

There have been countless times where I've posted something, had someone reply to it, and then realize I've made a typo or missed an important detail. Only having the option to "Delete and Edit" makes it impossible for me to fix it without losing people's replies. In this case, the actual content of the note hasn't meaningfully changed.

That being said, I understand that not everyone limits themselves to fixing simple typos, which is why I think users need to be notified if a note they reacted/replied to has been edited (as @saschanaz has mentioned) so they can decide if they want to change their reaction/reply.

Because note editing is likely going to be something people either agree or disagree on, I think be a good idea to allow admins the ability to enable/disable direct editing of notes.

• Misskeyでリモートの編集履歴を保持する必要はない、編集履歴はオリジナルを参照すれば良い（Mastodonは嘘をつかないだろう） 編集済みフラグを保持し、何かしらの編集がされたことを表示するだけ

Having the history of note edits is invaluable for moderating an instance. If someone posts something that's problematic and edits it after the fact, as a moderator, I still need to know what was originally said so I can decide if I need to take further action.

[dakkar]

another very good reason to keep full editing history: I can only see the note on the remote server if it's a public note; any "followers only" or direct note won't be visible