ciao icon indicating copy to clipboard operation
ciao copied to clipboard

Coffeescript binary assumed path isn't always correct

Open sandfox opened this issue 12 years ago • 2 comments

If this module is included anywhere in a module tree that already includes coffee-script then the assumption that the coffee script binary will be inside ciao's node_modules folder will probably no longer be true.

This may or may not be related to this (long) issue on npm isaacs/npm#1341

End result is that everything breaks if coffee-script binary isn't there :-(

error: Failed to start child process

sandfox avatar May 27 '13 23:05 sandfox

I have implemented a (quite frankly god awful but I think just about better than what was there before) solution in my branch sandfox/ciao@b3f2ba327073447396f6131e89eb122344c9c206

It's still pretty brittle but now more dynamic and will ensure that at least the same version of coffeescript is used for running ciao and the child processes. Am happy to open a PR to pull it in as interim solution.

Longer term I think there must be a better way of doing it, out of interest whats the reasoning behind spawning the child process rather than just doing it in the main process?

sandfox avatar May 29 '13 18:05 sandfox

Actually scrap that branch - it still breaks in lots of instances when ciao is included as a sub module inside another app

sandfox avatar May 29 '13 19:05 sandfox