console icon indicating copy to clipboard operation
console copied to clipboard

[Blocked] - Disabled support tools if cluster is not registered.

Open bexsoft opened this issue 3 years ago • 9 comments

What does this do?

  • Redirect to register page when not register vars are set
  • Added double column for register page

How does it look?

Screen Shot 2022-07-12 at 14 41 53 Screen Shot 2022-07-12 at 14 41 46 Screen Shot 2022-07-12 at 14 41 38 Screen Shot 2022-07-12 at 14 36 50 Screen Shot 2022-07-12 at 14 36 43 Screen Shot 2022-07-12 at 14 36 35 Screen Shot 2022-07-12 at 14 36 28

Signed-off-by: Benjamin Perez [email protected]

bexsoft avatar Jul 12 '22 19:07 bexsoft

Updated screens: Screen Shot 2022-07-13 at 17 42 44 Screen Shot 2022-07-13 at 17 42 27

bexsoft avatar Jul 13 '22 22:07 bexsoft

Does this mean that an unregistered cluster can't run speedtest?

harshavardhana avatar Jul 15 '22 17:07 harshavardhana

Does this mean that an unregistered cluster can't run speedtest?

any answer to my question?

harshavardhana avatar Jul 16 '22 04:07 harshavardhana

Does this mean that an unregistered cluster can't run speedtest?

Yes, that's correct

bexsoft avatar Jul 16 '22 04:07 bexsoft

Yes, that's correct

Isn't this going to be a breaking change and perhaps a large change for even POC customers? - are we saying that even POCs will have to be registered?

harshavardhana avatar Jul 16 '22 04:07 harshavardhana

Yes, that's correct

Isn't this going to be a breaking change and perhaps a large change for even POC customers? - are we saying that even POCs will have to be registered?

I see, yeah the requirement was to request for register the cluster to enable the tools actions. I think we might need to review this further.

bexsoft avatar Jul 16 '22 04:07 bexsoft

If possible can we commit the changes to Register.tsx file in a different PR? I believe those changes can go without any problem but not 100% sure

reivaj05 avatar Jul 18 '22 18:07 reivaj05

Is this clarified today? @bexsoft

harshavardhana avatar Aug 03 '22 00:08 harshavardhana

Is this clarified today? @bexsoft

Yes Harsha, We will be implementing a couple of changes on this & mc as well. PR will continue blocked until then

bexsoft avatar Aug 03 '22 01:08 bexsoft

This PR is blocked, no need for a review right now.

PR Ready for review

bexsoft avatar Oct 25 '22 00:10 bexsoft