C# 有现成的System.DateTime.FromOADate方法问什么不用，是有什么特殊处理吗？

[shaofing]

https://github.com/mini-software/MiniExcel/blob/f6992131ec09207e186345b3bced7e48f8e98407/src/MiniExcel/Utils/DateTimeHelper.cs#L63

C# 有现成的System.DateTime.FromOADate方法问什么不用，自己实现的是有什么特殊处理吗？

[shps951023]

@shaofing IsDateTimeFormat 还有 isDate1904 特别处理

[shaofing]

看了DateTimeHelper.FromOADate的实现与System.DateTime.FromOADate（.Net4.5反编译）的实现逻辑一模一样，好像没有处理isDate1904相关

[shps951023]

@shaofing 👍我再确认下，假如没问题，预计下个版本移除 DateTimeHelper.FromOADate 或是能尝试PR? 这是你发现的 issue

[michelebastione]

@shps951023 If I understood this correctly there is a superfluous reimplementation of the Datetime.FromOADate function. I checked and when you expand the tick calculations they are perfectly identical. I can add the simplification to my next PR.

[shps951023]

@shps951023 If I understood this correctly there is a superfluous reimplementation of the Datetime.FromOADate function. I checked and when you expand the tick calculations they are perfectly identical. I can add the simplification to my next PR.

Please, thanks 🐱‍🏍