Feat/soft delete
Hi,
I added the option for soft for both InMemory and Relational, need to add Redis
I made it optional, and also I prevent getting the URL if the URL was soft deleted, please let me know what you think
I've merged the release branch to prevent conflicts in the future, that made the PR a bit hard to follow, my new Impl starts at:
"Merge remote-tracking branch 'origin/release/0.2.0' into release/0.2.0"
#79
Codecov Report
Merging #166 (df3172f) into release/0.2.0 (ededa7b) will decrease coverage by
0.54%. The diff coverage is0.00%.
@@ Coverage Diff @@
## release/0.2.0 #166 +/- ##
=================================================
- Coverage 17.52% 16.98% -0.55%
=================================================
Files 40 41 +1
Lines 1335 1378 +43
Branches 50 51 +1
=================================================
Hits 234 234
- Misses 1069 1111 +42
- Partials 32 33 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/routes/url.ts | 0.00% <0.00%> (ø) |
|
| src/services/auth/drivers/bearerToken/index.ts | 0.00% <ø> (ø) |
|
| src/services/storage/drivers/inMemory/index.ts | 0.00% <0.00%> (ø) |
|
| src/services/storage/drivers/relational/index.ts | 0.00% <0.00%> (ø) |
|
| ...relational/migrations/20210401143602_softDelete.ts | 0.00% <0.00%> (ø) |
|
| src/services/storage/index.ts | 0.00% <0.00%> (ø) |
|
| src/services/storage/types/url.ts | 0.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update ededa7b...df3172f. Read the comment docs.
@lesagi please see Snir comments
Hi, Snir was updated yesterday, it was WIP, now can be reviewed again, thanks for the heads up!