miniurl icon indicating copy to clipboard operation
miniurl copied to clipboard

url cleanup upgrade

Open shay123g opened this issue 4 years ago • 6 comments

Closes #16

shay123g avatar Mar 13 '21 16:03 shay123g

Codecov Report

Merging #148 (75c9a8f) into release/0.2.0 (5afc392) will increase coverage by 0.51%. The diff coverage is 25.92%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/0.2.0     #148      +/-   ##
=================================================
+ Coverage          18.11%   18.63%   +0.51%     
=================================================
  Files                 36       36              
  Lines               1325     1358      +33     
  Branches              46       47       +1     
=================================================
+ Hits                 240      253      +13     
- Misses              1057     1077      +20     
  Partials              28       28              
Impacted Files Coverage Δ
src/config/index.ts 0.00% <0.00%> (ø)
src/config/types.ts 0.00% <0.00%> (ø)
src/index.ts 0.00% <0.00%> (ø)
src/services/storage/drivers/inMemory/index.ts 0.00% <0.00%> (ø)
src/services/storage/drivers/relational/index.ts 0.00% <0.00%> (ø)
src/services/storage/drivers/relational/types.ts 0.00% <0.00%> (ø)
src/services/storage/index.ts 0.00% <0.00%> (ø)
src/config/validate.ts 91.52% <75.00%> (-1.21%) :arrow_down:
src/config/__test__/helpers.ts 100.00% <100.00%> (ø)
src/config/normalize.ts 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5afc392...75c9a8f. Read the comment docs.

codecov[bot] avatar Mar 13 '21 16:03 codecov[bot]

@shay123g

That's only for the InMemory driver. What about the Relational driver?

Also, we've talked about a possible flag in the config to specify whether to delete from created_at date or from last_used date.

SnirShechter avatar Mar 13 '21 17:03 SnirShechter

@shay123g

That's only for the InMemory driver. What about the Relational driver?

Also, we've talked about a possible flag in the config to specify whether to delete from created_at date or from last_used date.

  1. I will fix
  2. Relational - @Danielg212 still working on it, he need to complete the fix for deleteOverdue

shay123g avatar Mar 13 '21 18:03 shay123g

@SnirShechter pls check

shay123g avatar Mar 14 '21 12:03 shay123g

@lesagi I already accept your changes and commited them.. thanks for the explanation though. I asked for review again to check those changes and approve\request more changes

shay123g avatar Mar 16 '21 14:03 shay123g

@SnirShechter conflicts resolved

shay123g avatar Mar 29 '21 11:03 shay123g