url cleanup upgrade
Closes #16
Codecov Report
Merging #148 (75c9a8f) into release/0.2.0 (5afc392) will increase coverage by
0.51%. The diff coverage is25.92%.
@@ Coverage Diff @@
## release/0.2.0 #148 +/- ##
=================================================
+ Coverage 18.11% 18.63% +0.51%
=================================================
Files 36 36
Lines 1325 1358 +33
Branches 46 47 +1
=================================================
+ Hits 240 253 +13
- Misses 1057 1077 +20
Partials 28 28
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/config/index.ts | 0.00% <0.00%> (ø) |
|
| src/config/types.ts | 0.00% <0.00%> (ø) |
|
| src/index.ts | 0.00% <0.00%> (ø) |
|
| src/services/storage/drivers/inMemory/index.ts | 0.00% <0.00%> (ø) |
|
| src/services/storage/drivers/relational/index.ts | 0.00% <0.00%> (ø) |
|
| src/services/storage/drivers/relational/types.ts | 0.00% <0.00%> (ø) |
|
| src/services/storage/index.ts | 0.00% <0.00%> (ø) |
|
| src/config/validate.ts | 91.52% <75.00%> (-1.21%) |
:arrow_down: |
| src/config/__test__/helpers.ts | 100.00% <100.00%> (ø) |
|
| src/config/normalize.ts | 100.00% <100.00%> (ø) |
|
| ... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 5afc392...75c9a8f. Read the comment docs.
@shay123g
That's only for the InMemory driver. What about the Relational driver?
Also, we've talked about a possible flag in the config to specify whether to delete from created_at date or from last_used date.
@shay123g
That's only for the InMemory driver. What about the Relational driver?
Also, we've talked about a possible flag in the config to specify whether to delete from created_at date or from last_used date.
- I will fix
- Relational - @Danielg212 still working on it, he need to complete the fix for deleteOverdue
@SnirShechter pls check
@lesagi I already accept your changes and commited them.. thanks for the explanation though. I asked for review again to check those changes and approve\request more changes
@SnirShechter conflicts resolved