mapserver icon indicating copy to clipboard operation
mapserver copied to clipboard

Smartshop poi display

Open thomasrudin opened this issue 6 years ago • 2 comments

Position marker for smartshop does not make sense currently: The 4 markers overlap and 3 of them are not visible.

  • pandorabox-issue: https://github.com/pandorabox-io/pandorabox.io/issues/369

Possible solutions

  • Compact all the info into one marker
  • Scatter marker positions

thomasrudin avatar Dec 06 '19 07:12 thomasrudin

Maybe issue is here: https://github.com/minetest-mapserver/mapserver/blob/4a7722c8bc4ae6bd0f3e4e9dbe1677080c81ab65/mapobject/smartshop.go#L24-L69 it creates 4 POI objects in loop while it should probably just collect data and create one POI after loop.

edit. Now reading description again I think this was already known but here's my opinion: Just concat everything into single POI and then if needed update UI elements so that all info can be displayed nicely.

S-S-X avatar Jul 01 '20 20:07 S-S-X

Just fyi (or for me in the future when i find some time and motivation for this :smile:)

Here is the drawing logic on the frontend for the POI's:

https://github.com/minetest-mapserver/mapserver/blob/ec9054b4f8aabf5504e04294f4c9afc7aeb1864e/static/js/map/overlays/AbstractIconOverlay.js#L81-L130

Obviously not intended for overlapping markers on the same position :yum:

This triggers the createPopup() functions on the subclasses:

https://github.com/minetest-mapserver/mapserver/blob/ec9054b4f8aabf5504e04294f4c9afc7aeb1864e/static/js/map/overlays/ShopOverlay.js#L34-L40

@Omikhleia

BuckarooBanzay avatar Jul 02 '20 05:07 BuckarooBanzay