minecraft-dev
Automatically suggest adding/removing remap=true on mixin-related annotations
Could you add a warning for mixin annotations when the remap value of an annotation doesn't match the obfuscation state of the target?
Relevant annotations I've found:
@Mixin
@Accessor
@Invoker
@Shadow
@ModifyConstant
@Inject
@ModifyVariable
@At
@ModifyArg
@ModifyArgs
@Redirect
This will also be added to @Overwrite in the future: https://github.com/SpongePowered/Mixin/issues/179#issuecomment-313033777
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
This should be specific for targetting non-obfuscated targets, without remap = false.
@DenWav From https://github.com/SpongePowered/Mixin/issues/551, annotations may still require an explicit remap=true in some cases even though it is the default.
A good first step for this would be to suppress the "default annotation value" warning and quick fix for the remap field, since it can be misleading. Then, we could work on re-adding an inspection explicitly for the remap that is aware of the unconventional context-sensitive behavior.
