MinecraftDev icon indicating copy to clipboard operation
MinecraftDev copied to clipboard

Warn about remapped methods not implementing custom interfaces

Open The-Fireplace opened this issue 4 years ago • 0 comments

Problem: Let's say we have a custom interface with some methods that match the names of those in a vanilla file such as Entity where mappings have been applied to give it the names it has. If I have a custom Entity implement this interface, it will work fine in the dev environment then fail to work after being compiled because the methods on Entity no longer have been remapped and no longer have the same name.

Proposed solution: Display an error on the interface name for implements SomeInterface, preferably also on the method name if it is overridden in the file.

Other setup to consider: The custom interface extends a vanilla interface. We should only get errors if the methods from the custom interface have this kind of conflict, not the vanilla one it extends.

The-Fireplace avatar Nov 20 '21 15:11 The-Fireplace