fix(app): stop propagation on mode not found exception

[zds-s]

• Add stopPropagation() method to prevent further exception handling
• Improve error handling in ModeNotFoundHandler

Summary by CodeRabbit

• New Features

  • Updated the Chinese localization for the 'not_found' message to provide clearer context ("数据不存在" translates to "data does not exist").
  • Introduced a new test for login functionality to ensure proper handling of existing usernames.

• Bug Fixes

  • Improved error handling for not found exceptions, ensuring proper response management.

• Refactor

  • Enhanced the handleResponse method to improve clarity and functionality.

[coderabbitai[bot]]

Walkthrough

The ModeNotFoundHandler class in the app/Exception/Handler/ModeNotFoundHandler.php file has been updated to include a call to the stopPropagation() method within the handleResponse function. This change occurs prior to the creation and return of a new Result object with a ResultCode::NOT_FOUND. The isValid method remains unchanged. Additionally, the localization file for Chinese has been updated to change the translation for the 'not_found' key. A new test method has been added to the PassportControllerTest class to verify login functionality for an existing username. Furthermore, the UserRepositoryTest class has had the @coversNothing annotation removed.

Changes

File Path	Change Summary
app/Exception/Handler/ModeNotFoundHandler.php	Updated handleResponse method to include $this->stopPropagation(); before returning a Result.
storage/languages/zh_CN/result.php	Updated translation for 'not_found' from '未找到' to '数据不存在'.
tests/Feature/Admin/PassportControllerTest.php	Added testLoginExistUsername method and import statement for Type enum.
tests/Feature/Repository/UserRepositoryTest.php	Removed @coversNothing annotation from the class-level docblock.

Poem

In the handler's gentle sway,
A new call leads the way,
Stop the flow, let errors cease,
With Result::NOT_FOUND, find peace.
A hop, a skip, a joyful cheer,
For changes bright, we hold so dear! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 138b9abe1c667937015ab58a2216106ead976032 and bc740cf02bb609185dd0704468b54c728844fbeb.

📒 Files selected for processing (2)

• tests/Feature/Admin/PassportControllerTest.php (2 hunks)
• tests/Feature/Repository/UserRepositoryTest.php (0 hunks)

💤 Files with no reviewable changes (1)

• tests/Feature/Repository/UserRepositoryTest.php

🚧 Files skipped from review as they are similar to previous changes (1)

• tests/Feature/Admin/PassportControllerTest.php

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.