min icon indicating copy to clipboard operation
min copied to clipboard

iframe content doesn't request "Mic and Video" permissions

Open steveb85 opened this issue 1 year ago • 5 comments

  • Min Version: 1.33
  • Operating system: macS 10.14

Expected Behavior

An embeded video call in an iFrame would request video and audio input

Actual Behavior

while the call is embeded in an iframe, no options appear to give permissions, so the frame becomes unusable, if you go directly to the source of the iframe, everything works as expected.

To Reproduce

the problem i have found is using element with jitsi for calls. https://app.element.io/ and make a call using the jitsi plugin to reproduce, though i'm confident that this would reproduce in other setups, happy to share access to aguest room on our server to anyone needing to test. (message me directly)

steveb85 avatar Sep 30 '24 14:09 steveb85

This was originally an intentional decision: https://github.com/minbrowser/min/blob/429b5bffcefdf12b2c9d07550d79dd81a3f80016/main/permissionManager.js#L89-L93

Is the Iframe URL on the same domain as the parent page? For that case, we could probably enable this fairly easily.

For third-party frames, we need to design a new UI for this so it's clear which domain is requesting the permission, and also make sure we match how other browsers handle this.

PalmerAL avatar Oct 01 '24 16:10 PalmerAL

Oh i see, that makes sense, in this instance it’s not the same domain, the parent is the element instance, and the iframe is jitsi, who is hosting the calls… my average annoying workaround is just to go to the source of the iframe in a new tab, however, i’m now facing the issue where i can’t screen share, and it seems perhaps this too is by design? @PalmerAL

steveb85 avatar Oct 01 '24 18:10 steveb85

Yes unfortunately, see #1965

PalmerAL avatar Oct 02 '24 14:10 PalmerAL

@PalmerAL thanks for the answers on this! any knowledge of (if) this is part of a planned roadmap? Love min and the whole concept. but this does make it hard to use as a daily. would be interested in sponsoring potentially to get implemented, i don't have any time left to look at it myself.

steveb85 avatar Oct 03 '24 13:10 steveb85

It hasn't been, but I think it would be a reasonable thing to work on. I may have some time soon, but I don't want to guarantee anything.

PalmerAL avatar Oct 07 '24 20:10 PalmerAL