Mikhail Swift

Results 77 comments of Mikhail Swift

The gitlab jwks url issue has been patched with https://github.com/testifysec/go-witness/pull/3 witness v0.1.10 with this included will be available shortly

Great ideas! I really like hashing out sensitive variables to still offer some insight versus straight up ignoring them. I think making a collection of known variables that contain sensitive...

Looks like a good foundation for a list of the vars

Something that may be worth pursuing in a more general sense is the time each attestor started and ended from the attestor context's perspective.

Can you provide more detail on what you mean by this?

I don't think Witness sign should modify what it's signing at all. The `witness sign` cli can theoretically be used to sign any arbitrary file. This is both a benefit...

Just need to hook the config file into this function https://github.com/testifysec/witness/blob/ebb7c3d23f2529a0f40d372b7b3ec5546e6a7847/pkg/attestation/context.go#L27 Any hash calculations done in attestors should ask the context which hashes it needs to use.

commit should be `feat: xxxx` to match conventional commit structure and change log generator to work correctly

Some thoughts around this: A simple first iteration would to be just to try every attestor -- though the Snyk attestor should be excluded from this. This is essentially what...

What's the status of this PR?