core.matrix icon indicating copy to clipboard operation
core.matrix copied to clipboard

Clatrix implementation of PEigenDecomposition expects different keys for :return map

Open retnuh opened this issue 10 years ago • 1 comments

Hi there, the docs for c.c.matrix.linear/eigen currently state that a map with the keys :Q and :A will be returned. However, the clatrix implementation returns keys for :Q, :iA and :rA. I'm guessing that this is related to 184 but until a final solution is decided on, either the implementations should match the docs, or the docs should mention the variants, or something else that doesn't require people to go grubbing around in the source to figure out why it appears to only partially work...

retnuh avatar Nov 26 '15 16:11 retnuh

Thanks for the report. I don't personally use these functions much so I don't really have a strong view on what the API should look like.

Do you have a proposal? Right now it seems to be a Clatrix issue for not following the core.matrix docs, but I'm happy to change the core.matrix API given convincing arguments.

@astanin @dmarjenburgh @mschuene @Gerrrr any views since you were involved in the previous discussion / implementation?

mikera avatar Nov 27 '15 00:11 mikera