HidLibrary icon indicating copy to clipboard operation
HidLibrary copied to clipboard

Only return valid data on Read

Open benedekkupper opened this issue 7 years ago • 4 comments

Reading reports should always return with the actual size of the read report. E.g. in case of multi-report devices, or when read actually fails. For the latter the proper course of action is to set the status to NoDataRead and return with zero size array.

benedekkupper avatar Jun 17 '18 19:06 benedekkupper

So there was another PR I needed to merge and it has caused some conflicts. If you could resolve those and push an update, I'll get this merged in. Sorry for the delay!

mikeobrien avatar Jun 25 '18 14:06 mikeobrien

Done, you can go ahead with merging now I believe.

benedekkupper avatar Jun 26 '18 16:06 benedekkupper

Will this ever be merged?

benedekkupper avatar Nov 22 '18 20:11 benedekkupper

Sorry, it's been a few years. If you can merge in the previous commit, I can get this in there.

amullins83 avatar Dec 23 '19 14:12 amullins83