mientjan
Fixed headings bug for Debug & Release modes
PR #79 is functional only in Debug mode. This one isn't pretty but I think I didn't break anything and it works in both Debug and Release modes.
@alsotang I'll do the same PR on your fork EDIT: seems I can't PR on your fork... :(
@mientjan do you think you could review and merge this PR since headings aren't correctly rendered by the lib in React Native 0.57
absolutely you can pr my fork. but perhaps mine and this one are the same repo name, or some problem with comman parent. I dont know.
And I would merge this pr and publish a new version. Yep this pr seems some ugly, but when we talk about a random unique key value, it's ok.
I think this commit is also ok, https://github.com/alsotang/react-native-markdown-renderer/commit/ffe99bb632791e5f4a156f637ff02b6a4422f3ab
Can you give more advise?
because type is just a string. so we can judge string, but ignore the key.
I try this in debug mode and release mode
For those waiting on this PR, we switched to react-native-simple-markdown, and the transition was remarkably seamless. Granted, my project doesn't use even the majority of Markdown features.
I have forked this project and merged all outstanding PR's that made sense (including a similar one to this one that fixed the issue) here: https://github.com/iamacup/react-native-markdown-display/
or react-native-markdown-display on npm
in case anyone else comes accross this and needs the merged PRs
