tobii icon indicating copy to clipboard operation
tobii copied to clipboard

No/wrong recalculating of counter after removal of item

Open domaxistd opened this issue 3 years ago • 3 comments

Hello, it seems that the counter does not recalculate after an item is removed.

  1. i add several images to the lightbox -> counter is right
  2. i remove an image -> counter is wrong (shows too much items, numbers are mixed)

Is there any workaround or quick fix?

Thanks in advance! Maxi

domaxistd avatar Jun 21 '22 15:06 domaxistd

Hi @domaxistd

first of all, thanks for opening this issue.

I have to investigate, never used the tobii counter feature myself. Looks like it's related to https://github.com/midzer/tobii/issues/93.

midzer avatar Jun 23 '22 06:06 midzer

Thanks for the fast respond! @midzer

Another problem that occurs is that when i remove and add multiple items, the lightbox shows too much items. For example:

  • i have 3 items added to the lightbox
  • the lightbox counter shows 8 items
  • i can swipe 8 times before the lightbox closes itself even though there are only 3 items added (it loops through the 3 items)

I have already tried to reset the lightbox after i remove an item but that doesn't seem to work.

Maybe this helps you find the problem.

domaxistd avatar Jun 29 '22 09:06 domaxistd

Any progress or findings yet?

domaxistd avatar Aug 31 '22 09:08 domaxistd

@domaxistd Sorry, I was rather busy the last months. Now, over the holidays I can investigate.

midzer avatar Dec 23 '22 19:12 midzer

Should be fixed by https://github.com/midzer/tobii/commit/b84f9be159d4371ca728c7f048e8c480db0409c2

Can you give it a try, @domaxistd?

midzer avatar Dec 24 '22 01:12 midzer

@midzer problem solved, thanks!

domaxistd avatar Jan 05 '23 10:01 domaxistd