pycstruct icon indicating copy to clipboard operation
pycstruct copied to clipboard
verified publisher icon midstar

Update type hint in add method of StructDef

Open pmbarrett314 opened this issue 3 years ago • 5 comments

Since StructDef.add can accept instances of other subclasses of _BaseDef for the datatype, this type hint doesn't cover all possible cases, which annoys my IDE and type checker.

pmbarrett314 avatar Jul 13 '22 22:07 pmbarrett314

Hi! Change looks fine for me but please run black (https://pypi.org/project/black/) on your updated files and update your branch with the result. Our CI fails unless all files has been "blacked"

midstar avatar Jul 14 '22 06:07 midstar

I ran black and committed that. Looks like CI is finding some pylint issues now. I don't think either of these are in my change, though, it is just a single line change in a doc comment.

pmbarrett314 avatar Jul 28 '22 01:07 pmbarrett314

Sorry for the late response. I'm on vacation and don't have access to a computer. I will check it when I'm back.

midstar avatar Aug 05 '22 05:08 midstar

No worries, it's not exactly an urgent bug. Have a good vacation!

pmbarrett314 avatar Aug 09 '22 06:08 pmbarrett314

Author

The issues on this pull request is due to changed rules in black and pylint. I have fixed this on master branch. Please perform a new pull request against the new master and it will probably be fine :-)

midstar avatar Aug 13 '22 11:08 midstar