winget-pkgs icon indicating copy to clipboard operation
winget-pkgs copied to clipboard

Normalize Kiwix.WikiMed 2.0.4.0

Open Trenly opened this issue 3 years ago • 4 comments

null

Microsoft Reviewers: Open in CodeFlow

Trenly avatar Aug 30 '22 23:08 Trenly

Service Badge  Service Badge  

wingetbot avatar Aug 30 '22 23:08 wingetbot

/AzurePipelines run

wingetbot avatar Aug 30 '22 23:08 wingetbot

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 30 '22 23:08 azure-pipelines[bot]

Hello @Trenly, During validation, the MSIX package was evaluated. There were either inconsistencies or values not present in the manifest. Please adjust the manifest accordingly.

Template: msftbot/validationError/manifest/installerValidation

ghost avatar Aug 30 '22 23:08 ghost

/AzurePipelines run

wingetbot avatar Aug 31 '22 17:08 wingetbot

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 31 '22 17:08 azure-pipelines[bot]

Hello @Trenly, The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

Template: msftbot/validationError/installation/general

ghost avatar Aug 31 '22 17:08 ghost

I think this needs an engineer -

2022-08-31 10:23:47.034 [FAIL] WindowsPackageManager.dll!00007FFD4B405E12: ReturnHr(1) tid(22b4) 80072EFF     Msg:[winrt::hresult_error: The text associated with this error code could not be found.] 

Trenly avatar Sep 02 '22 17:09 Trenly

cc @denelon

Trenly avatar Sep 02 '22 17:09 Trenly

Per log there is an exception WindowsPackageManager.dll - resulting WININET_E_CONNECTION_RESET.

2022-08-31 10:23:47.057 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\MsixInfo.cpp(311)\WindowsPackageManager.dll!00007FFD4B296FB7: (caller: 00007FFD4B23E5C0) Exception(1) tid(22b4) 80072EFF 2022-08-31 10:23:47.057 [CLI ] Caught wil::ResultException: D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\MsixInfo.cpp(311)\WindowsPackageManager.dll!00007FFD4B296FB7: (caller: 00007FFD4B23E5C0) Exception(1) tid(22b4) 80072EFF

Attempted multiple retries on our sandbox where it kept failing with different error code

Microsoft is not responsible for, nor does it grant any licenses to, third-party packages. Successfully verified installer hash Starting package install... Installer failed with exit code: 0x80070002 : The system cannot find the file specified.

Also, attempted retries outside sandbox. One of the attempts failed with 0x80072eff error code but the next retry attempt worked fine. image

Given this is just normalization change and works fine with retry considering to applying waiver for this.

Madhusudhan-MSFT avatar Sep 05 '22 22:09 Madhusudhan-MSFT

@wingetbot waivers Add Validation-Installation-Error

Madhusudhan-MSFT avatar Sep 08 '22 18:09 Madhusudhan-MSFT

/AzurePipelines run

wingetbot avatar Sep 08 '22 18:09 wingetbot

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 08 '22 18:09 azure-pipelines[bot]

Hello @Trenly,

During validation, the MSIX package was evaluated. There were either inconsistencies or values not present in the manifest. Please adjust the manifest accordingly.

Template: msftbot/validationError/manifest/installerValidation

ghost avatar Sep 08 '22 18:09 ghost

****************************************************************************************
Manifest Validation
****************************************************************************************
Status: Completed
##[error] Result: Failed
##[error] One or more errors occurred. (Manifest Error: Failed to process installer. Field: InstallerUrl Value: https://github.com/kiwix/kiwix-js-windows/releases/download/v2.0.4-WikiMed/KiwixWebAppWikiMed_2.0.4.0_AnyCPU.appxbundle
) Manifest Error: Failed to process installer. Field: InstallerUrl Value: https://github.com/kiwix/kiwix-js-windows/releases/download/v2.0.4-WikiMed/KiwixWebAppWikiMed_2.0.4.0_AnyCPU.appxbundle
Finishing: Validate Manifest

https://dev.azure.com/ms/winget-pkgs/_build/results?buildId=368823&view=logs&j=1c216ba8-f9ef-5707-496b-69e30b6cb45a&t=d5938111-0e28-5713-0070-4b1bb7df6b82&l=64

denelon avatar Sep 08 '22 18:09 denelon

****************************************************************************************
Manifest Validation
****************************************************************************************
Status: Completed
##[error] Result: Failed
##[error] One or more errors occurred. (Manifest Error: Failed to process installer. Field: InstallerUrl Value: https://github.com/kiwix/kiwix-js-windows/releases/download/v2.0.4-WikiMed/KiwixWebAppWikiMed_2.0.4.0_AnyCPU.appxbundle[](https://github.com/kiwix/kiwix-js-windows/releases/download/v2.0.4-WikiMed/KiwixWebAppWikiMed_2.0.4.0_AnyCPU.appxbundle)
) Manifest Error: Failed to process installer. Field: InstallerUrl Value: https://github.com/kiwix/kiwix-js-windows/releases/download/v2.0.4-WikiMed/KiwixWebAppWikiMed_2.0.4.0_AnyCPU.appxbundle[](https://github.com/kiwix/kiwix-js-windows/releases/download/v2.0.4-WikiMed/KiwixWebAppWikiMed_2.0.4.0_AnyCPU.appxbundle)
Finishing: Validate Manifest

dev.azure.com/ms/winget-pkgs/_build/results?buildId=368823&view=logs&j=1c216ba8-f9ef-5707-496b-69e30b6cb45a&t=d5938111-0e28-5713-0070-4b1bb7df6b82&l=64

As helpful as that error is. . . it really isn't. The installer URL's work for me, and other versions of WikiMed have passed validation. Is there anything saying why it couldn't be processed?

Trenly avatar Sep 08 '22 18:09 Trenly

I've assigned this to our current "on-call" to look and see what is failing so we can figure out what needs to be fixed in validation, or how we might provide a better message.

denelon avatar Sep 08 '22 20:09 denelon

/azp run

AmelBawa-msft avatar Sep 08 '22 20:09 AmelBawa-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 08 '22 20:09 azure-pipelines[bot]

Hello @Trenly,

During validation, the MSIX package was evaluated. There were either inconsistencies or values not present in the manifest. Please adjust the manifest accordingly.

Template: msftbot/validationError/manifest/installerValidation

ghost avatar Sep 08 '22 20:09 ghost

I've assigned this to our current "on-call" to look and see what is failing so we can figure out what needs to be fixed in validation, or how we might provide a better message.

Bumping this thread so it doesn't get marked No-Recent-Activity

Trenly avatar Sep 15 '22 12:09 Trenly

Manifest Error: Failed to process installer. Field: InstallerUrl Value: ...

@Trenly; @denelon , for this (and few other) PRs with the same error message above, the issue is occurring because the attempt to get the MSIX information directly from the installer URL is failing unexpectedly during the validation. This bug (tracked internally) needs to be fixed in the client code by potentially downloading the installer to the validation pipeline agent, and then attempting to get the MSIX info, instead of streaming them directly from the installer URL.

AmelBawa-msft avatar Sep 15 '22 15:09 AmelBawa-msft

@AmelBawa-msft can you create an Issue in the repository to track the change? That way we can link the PRs to the issue, and the community will know when we have the fix in place so these can be unblocked.

denelon avatar Sep 15 '22 16:09 denelon

Thanks for the detailed explanation! That makes a lot of sense

Trenly avatar Sep 15 '22 16:09 Trenly

We're actively working on the fix here. Once the fix has been implemented and released to our production environment, we will trigger the build again to see if this will get merged.

denelon avatar Oct 11 '22 21:10 denelon

/AzurePipelines run

AmelBawa-msft avatar Nov 07 '22 21:11 AmelBawa-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 07 '22 21:11 azure-pipelines[bot]

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost avatar Nov 07 '22 22:11 ghost

Hello Trenly, Validation has completed.

Template: msftbot/validationCompleted

ghost avatar Nov 07 '22 22:11 ghost

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

wingetbot avatar Nov 07 '22 22:11 wingetbot