winget-pkgs icon indicating copy to clipboard operation
winget-pkgs copied to clipboard

New Package: GnuWin32.Flex

Open soroshsabz opened this issue 1 year ago • 6 comments

ITNOA

Checklist for Pull Requests

Manifests

  • [x] Have you checked that there aren't other open pull requests for the same manifest update/change?
  • [x] This PR only modifies one (1) manifest
  • [x] Have you validated your manifest locally with winget validate --manifest <path>?
  • [x] Have you tested your manifest locally with winget install --manifest <path>?
  • [ ] Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

soroshsabz avatar Jan 15 '25 22:01 soroshsabz

@Dragon1573 Thanks for reviewing

inno original installation does not add bin path to windows env path, so after installation flex does not work, as same as bison and other GnuWin32 packages in winget

soroshsabz avatar Jan 16 '25 03:01 soroshsabz

@Dragon1573 if you have any idea to change easily installation process, and add bin in path, I welcome to learn it :)

soroshsabz avatar Jan 16 '25 03:01 soroshsabz

/AzurePipelines run

wingetbot avatar Jan 16 '25 03:01 wingetbot

If you have any idea to change easily installation process, and add bin in path, I welcome to learn it :)

Nope. For any other install technology than ZIP archives, winget.exe will only pass pre-defined switches to the install wizard. Registry modifications, envrionment variables modification and shortcuts creation will only been done by the install wizard itself.

If they peovides pre-built binary archives, you might able to try it with adding ArchiveBinariesDependOnPath: true.

Dragon1573 avatar Jan 16 '25 04:01 Dragon1573

/AzurePipelines run

wingetbot avatar Jan 16 '25 11:01 wingetbot

PATH problem is related to https://github.com/microsoft/winget-cli/issues/549 and I think we need to wait to add that features to winget

@Dragon1573 so any blockers exist for preventing merge this PR?

thanks

soroshsabz avatar Jan 16 '25 11:01 soroshsabz

@wingetbot run

stephengillie avatar Jan 16 '25 23:01 stephengillie

/AzurePipelines run

wingetbot avatar Jan 16 '25 23:01 wingetbot

@wingetbot run

soroshsabz avatar Jan 17 '25 08:01 soroshsabz

/AzurePipelines run

wingetbot avatar Jan 17 '25 08:01 wingetbot

@wingetbot run

stephengillie avatar Jan 17 '25 19:01 stephengillie

/AzurePipelines run

wingetbot avatar Jan 17 '25 19:01 wingetbot

What is meaning of Validation-Uapproved-URL?

soroshsabz avatar Jan 21 '25 20:01 soroshsabz

https://github.com/microsoft/winget-pkgs/labels/Validation-Unapproved-URL indicates that the file is hosted on a domain that allows user uploads, so a human (such as myself) must verify that the package comes from the actual developer, and isn't a rehosted package.

stephengillie avatar Jan 21 '25 22:01 stephengillie

Verify: image

stephengillie avatar Jan 21 '25 23:01 stephengillie

@Trenly How to reopen this PR?

soroshsabz avatar Feb 09 '25 12:02 soroshsabz

@wingetbot reopen

soroshsabz avatar Feb 09 '25 13:02 soroshsabz

@stephengillie I change all version in three files and remove -1

and push to branch, so I think if reopen this PR, all change apply

soroshsabz avatar Feb 09 '25 13:02 soroshsabz

Reopen with reason: Feedback addressed;

Trenly avatar Feb 09 '25 14:02 Trenly

/AzurePipelines run

wingetbot avatar Feb 09 '25 14:02 wingetbot

/AzurePipelines run

wingetbot avatar Feb 09 '25 14:02 wingetbot

/AzurePipelines run

wingetbot avatar Feb 09 '25 19:02 wingetbot

Verify: image

stephengillie avatar Feb 13 '25 18:02 stephengillie

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

wingetbot avatar Feb 13 '25 21:02 wingetbot