New Package: GnuWin32.Flex
ITNOA
Checklist for Pull Requests
- [x] Have you signed the Contributor License Agreement?
- [x] Is there a linked Issue? fixes #212691
Manifests
- [x] Have you checked that there aren't other open pull requests for the same manifest update/change?
- [x] This PR only modifies one (1) manifest
- [x] Have you validated your manifest locally with
winget validate --manifest <path>? - [x] Have you tested your manifest locally with
winget install --manifest <path>? - [ ] Does your manifest conform to the 1.9 schema?
Note: <path> is the directory's name containing the manifest you're submitting.
Microsoft Reviewers: Open in CodeFlow
@Dragon1573 Thanks for reviewing
inno original installation does not add bin path to windows env path, so after installation flex does not work, as same as bison and other GnuWin32 packages in winget
@Dragon1573 if you have any idea to change easily installation process, and add bin in path, I welcome to learn it :)
/AzurePipelines run
If you have any idea to change easily installation process, and add bin in path, I welcome to learn it :)
Nope. For any other install technology than ZIP archives, winget.exe will only pass pre-defined switches to the install wizard. Registry modifications, envrionment variables modification and shortcuts creation will only been done by the install wizard itself.
If they peovides pre-built binary archives, you might able to try it with adding ArchiveBinariesDependOnPath: true.
/AzurePipelines run
PATH problem is related to https://github.com/microsoft/winget-cli/issues/549 and I think we need to wait to add that features to winget
@Dragon1573 so any blockers exist for preventing merge this PR?
thanks
@wingetbot run
/AzurePipelines run
@wingetbot run
/AzurePipelines run
@wingetbot run
/AzurePipelines run
What is meaning of Validation-Uapproved-URL?
https://github.com/microsoft/winget-pkgs/labels/Validation-Unapproved-URL indicates that the file is hosted on a domain that allows user uploads, so a human (such as myself) must verify that the package comes from the actual developer, and isn't a rehosted package.
Verify:
@Trenly How to reopen this PR?
@wingetbot reopen
@stephengillie I change all version in three files and remove -1
and push to branch, so I think if reopen this PR, all change apply
Reopen with reason: Feedback addressed;
/AzurePipelines run
/AzurePipelines run
/AzurePipelines run
Verify:
Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.