winget-pkgs icon indicating copy to clipboard operation
winget-pkgs copied to clipboard

Delete Manifest: TeamSonarr.Sonarr version 4.0.4.1491

Open babblebauble opened this issue 1 year ago • 2 comments

Checklist for Pull Requests

Manifests

  • [x] Have you checked that there aren't other open pull requests for the same manifest update/change?
  • [x] This PR only modifies one (1) manifest
  • [ ] Have you validated your manifest locally with winget validate --manifest <path>?
  • [ ] Have you tested your manifest locally with winget install --manifest <path>?
  • [x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

babblebauble avatar Jul 06 '24 11:07 babblebauble

/azp run

hackean-msft avatar Jul 06 '24 14:07 hackean-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 06 '24 14:07 azure-pipelines[bot]

URL: https://github.com/Sonarr/Sonarr/releases/download/v4.0.4.1491/Sonarr.main.4.0.4.1491.win-x86-installer.exe OK

(Automated message - build 911)

stephengillie avatar Jul 08 '24 18:07 stephengillie

Hi @babblebauble,

This package is still available. Why should the manifest be removed?

stephengillie avatar Jul 08 '24 18:07 stephengillie

Hi @babblebauble,

This package is still available. Why should the manifest be removed?

The latest version is 4.0.6.1805 and there can only be one version 4 manifest in the repo since the installer only places the major.minor version information into the registry therefore the validation pipelines cannot differentiate between multiple 4.0 versions.

Submitting a version update and removal of the previous version in a single PR keeps resulting in an error

Manifest Error: DisplayVersion declared in the manifest has overlap with existing DisplayVersion range in the index. Existing DisplayVersion range in index: [ [4, 4]]

which takes ages to get resolved so submitting two separate PRs (one to remove the old version and another to update to the latest version) should get around that and be much more expedient.

babblebauble avatar Jul 08 '24 19:07 babblebauble

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

wingetbot avatar Jul 09 '24 03:07 wingetbot