winget-pkgs icon indicating copy to clipboard operation
winget-pkgs copied to clipboard

EpicGames.EpicGamesLauncher version 1.3.93.0: Remove InstallerLocale

Open StarsbySea opened this issue 1 year ago • 17 comments

  • [X] Have you signed the Contributor License Agreement?
  • [X] Have you checked that there aren't other open pull requests for the same manifest update/change?
  • [X] This PR only modifies one (1) manifest
  • [ ] Have you validated your manifest locally with winget validate --manifest <path>?
  • [ ] Have you tested your manifest locally with winget install --manifest <path>?
  • [ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Fixes an issue that was already fixed in #124201 (and which I'm sorry to say I had to fix again with the new installer configuration list), where specifying InstallerLocale would prevent upgrades or new installations in language regions that were not in the list. For EpicGames.EpicGamesLauncher specifically, which is itself a multilingual installer, there is no need to specify the InstallerLocale parameter. The current configuration file results in "A newer version of the package is available in the configured source, but does not apply to your system or requirements." when upgrading EpicGamesLauncher on a non-en-US machine. The following error is reported within the log:

2024-03-17 13:11:05.307 [CLI ] Installer [X86,wix,Machine,en-US] not applicable: Installer locale does not match required locale: en- USRequired locales: [] Or does not satisfy compatible match for Preferred Locales: [en-US].

This issue can be resolved by merging this pull request.


Microsoft Reviewers: Open in CodeFlow

StarsbySea avatar Mar 17 '24 05:03 StarsbySea

Service Badge  Service Badge  

wingetbot avatar Mar 17 '24 05:03 wingetbot

/AzurePipelines run

wingetbot avatar Mar 17 '24 05:03 wingetbot

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 17 '24 05:03 azure-pipelines[bot]

Url validation error

  • manifests\e\EpicGames\EpicGamesLauncher\1.3.93.0
    • https://www.epicgames.com/site
      • Http status code: Forbidden
    • https://www.epicgames.com/help
      • Http status code: Forbidden
    • https://www.epicgames.com/privacypolicy
      • Http status code: Forbidden
    • https://www.epicgames.com
      • Http status code: Forbidden
    • https://www.epicgames.com/tos
      • Http status code: Forbidden
    • https://www.epicgames.com/epic-games-store-faq
      • Http status code: Forbidden

wingetbot avatar Mar 17 '24 06:03 wingetbot

/AzurePipelines run

StarsbySea avatar Mar 18 '24 15:03 StarsbySea

Commenter does not have sufficient privileges for PR 144934 in repo microsoft/winget-pkgs

azure-pipelines[bot] avatar Mar 18 '24 15:03 azure-pipelines[bot]

/AzurePipelines run

wingetbot avatar Mar 18 '24 15:03 wingetbot

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 18 '24 15:03 azure-pipelines[bot]

Url validation error

  • manifests\e\EpicGames\EpicGamesLauncher\1.3.93.0
    • https://www.epicgames.com/site
      • Http status code: Forbidden
    • https://www.epicgames.com/help
      • Http status code: Forbidden
    • https://www.epicgames.com/privacypolicy
      • Http status code: Forbidden
    • https://www.epicgames.com
      • Http status code: Forbidden
    • https://www.epicgames.com/tos
      • Http status code: Forbidden
    • https://www.epicgames.com/epic-games-store-faq
      • Http status code: Forbidden

wingetbot avatar Mar 18 '24 16:03 wingetbot

URL:
Invalid URI: The hostname could not be parsed.

(Automated message - build 870)

stephengillie avatar Mar 18 '24 18:03 stephengillie

Hi @StarsbySea,

Unfortunately, it seems that this host has blocked our data centers. This isn't an error that I can waiver or get around. These URLs will need to be commented out of the locale file that accompanies this PR's installer file, before scanning can proceed:

Url validation error

  • manifests\e\EpicGames\EpicGamesLauncher\1.3.93.0

    • https://www.epicgames.com/site

      • Http status code: Forbidden
    • https://www.epicgames.com/help

      • Http status code: Forbidden
    • https://www.epicgames.com/privacypolicy

      • Http status code: Forbidden
    • https://www.epicgames.com

      • Http status code: Forbidden
    • https://www.epicgames.com/tos

      • Http status code: Forbidden
    • https://www.epicgames.com/epic-games-store-faq

      • Http status code: Forbidden

stephengillie avatar Mar 18 '24 19:03 stephengillie

URL:
Invalid URI: The hostname could not be parsed.

(Automated message - build 870)

stephengillie avatar Mar 19 '24 16:03 stephengillie

URL:
Invalid URI: The hostname could not be parsed.

(Automated message - build 871)

stephengillie avatar Mar 21 '24 16:03 stephengillie

URL:
Invalid URI: The hostname could not be parsed.

(Automated message - build 871)

stephengillie avatar Mar 22 '24 15:03 stephengillie

URL:
Invalid URI: The hostname could not be parsed.

(Automated message - build 873)

stephengillie avatar Mar 26 '24 14:03 stephengillie

URL:
Invalid URI: The hostname could not be parsed.

(Automated message - build 876)

stephengillie avatar Mar 27 '24 15:03 stephengillie

Hello @StarsbySea,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any recent activity. It will be closed if no further activity occurs within 3 days of this comment.

Template: msftbot/noRecentActivity