winget-create icon indicating copy to clipboard operation
winget-create copied to clipboard

Fix for Loading Invalid Manifests

Open The-Running-Dev opened this issue 1 year ago • 5 comments

  • Added new GetManifest, wrapped in try/catch.

  • Updated ParseExeInstallerType to use GetManifest

  • [x] Have you signed the Contributor License Agreement?

  • [ ] Are you working against an Issue?


Microsoft Reviewers: Open in CodeFlow

The-Running-Dev avatar Jul 11 '24 15:07 The-Running-Dev

@The-Running-Dev, do you have an example installer that I can use to try out this fix?

ryfu-msft avatar Jul 22 '24 19:07 ryfu-msft

/azp run

ryfu-msft avatar Jul 22 '24 19:07 ryfu-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 22 '24 19:07 azure-pipelines[bot]

Yes I do, try the XYplorer package (CologneCodeCompany.XYplorer). That package is the reason this fix exists.

The-Running-Dev avatar Jul 28 '24 16:07 The-Running-Dev

I feel the correct fix will be to look into why ManifestResource failed on specific manifest and fix the ManifestResource code instead of loading with XmlDocument unchecked and ignore all exceptions. (i.e. we need to look into CologneCodeCompany.XYplorer)

yao-msft avatar Dec 23 '24 21:12 yao-msft