Fix for Loading Invalid Manifests
-
Added new GetManifest, wrapped in try/catch.
-
Updated ParseExeInstallerType to use GetManifest
-
[x] Have you signed the Contributor License Agreement?
-
[ ] Are you working against an Issue?
Microsoft Reviewers: Open in CodeFlow
@The-Running-Dev, do you have an example installer that I can use to try out this fix?
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
Yes I do, try the XYplorer package (CologneCodeCompany.XYplorer). That package is the reason this fix exists.
I feel the correct fix will be to look into why ManifestResource failed on specific manifest and fix the ManifestResource code instead of loading with XmlDocument unchecked and ignore all exceptions. (i.e. we need to look into CologneCodeCompany.XYplorer)